[osg-users] [osganimation branch] Review, test, critics

[Julien Valentin]

Thanks Raymond
I pr the branch to master
Cheers


reedev wrote:
> Hi Julien, Robert,
> 
> The fix in the osganimation branch is working with VS2015 too. Fyi, the original nathan.osg in git is also working ok. Nice :-)
> 
> Cheers,
> Raymond
> 
> 
> 
> 
> On 11/6/2017 7:40 AM, Raymond de Vries wrote:
> 
> 
> >   Hi Julien,
> > 
> > Thanks for sharing. I will look at it this week, hopefully others can jump in too.
> > 
> > Cheers,
> > Raymond
> > 
> > 
> > 
> > On 11/3/2017 8:08 PM, Julien Valentin wrote:
> > 
> > 
> > >  
> > > > reedev wrote:
> > > > 
> > > > > Hi Julien,
> > > > > 
> > > > > Could you let me/us know to which mail you attached your modified 
> > > > > nathan? I can't find it. Can you let me/us know or send it directly?
> > > > > 
> > > > > Cheers
> > > > > Raymond
> > > > > 
> > > > > 
> > > > > 
> > > > > On 11/2/2017 7:30 PM, Julien Valentin wrote:
> > > > > 
> > > > > 
> > > > > > Hi
> > > > > > I'm a bit concerned about the nathan.osg compatibility with RigTransHW..
> > > > > > I attached in my last a modified version of nathan (without shared ss) that should work (and so would replace the current one in osgdata).
> > > > > > 
> > > > > > I would be glad if Raymond (or other) could validate this model (ideally under win32) with the following tests
> > > > > > softwaretest : osganimationviewer nathan2.osg
> > > > > > HWtest:          osganimationhardware --number 1 nathan2.osg
> > > > > > (Don't forget I changed the maxnumbones type from int to uint in skinning.vert )
> > > > > > Once these tests validated elsewhere than my computer, It will confort me in the validity of the branch so i can make PRs to master (and to osgdata).
> > > > > > 
> > > > > > Cheers
> > > > > > 
> > > > > > 
> > > > > > robertosfield wrote:
> > > > > > 
> > > > > > 
> > > > > > > Hi Raymond & Julien,
> > > > > > > 
> > > > > > > On 2 November 2017 at 14:17, Raymond de Vries < ()> wrote:
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > > I have not seen any issues in our own use of the osgAnimation. We tested in a few different setups and all seems ok.
> > > > > > > > 
> > > > > > > > The only thing is that the example did not work for me with Visual Studio 2015, while it does work for Julien.
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > >  Thanks for the testing.
> > > > > > > 
> > > > > > > 
> > > > > > > Julian, if you feel osganimation is now ready could you generate a PR for the branch and I'll go ahead and merge it.
> > > > > > > 
> > > > > > > 
> > > > > > > Cheers,
> > > > > > > Robert.
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > ------------------
> > > > > > > Post generated by Mail2Forum
> > > > > > > 
> > > > > > > 
> > > > > >  ------------------
> > > > > > Read this topic online here:
> > > > > > http://forum.openscenegraph.org/viewtopic.php?p=72293#72293 (http://forum.openscenegraph.org/viewtopic.php?p=72293#72293)
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > _______________________________________________
> > > > > > osg-users mailing list
> > > > > > 
> > > > > > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org (http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org)
> > > > > > 
> > > > > > 
> > > > > > ---
> > > > > > This email has been checked for viruses by AVG.
> > > > > > http://www.avg.com (http://www.avg.com)
> > > > > > 
> > > > > > 
> > > > >  _______________________________________________
> > > > > osg-users mailing list
> > > > > 
> > > > > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org (http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org)
> > > > > 
> > > > > ------------------
> > > > > Post generated by Mail2Forum
> > > > > 
> > > >  
> > > > ------------------
> > > > Read this topic online here:
> > > > http://forum.openscenegraph.org/viewtopic.php?p=72299#72299 (http://forum.openscenegraph.org/viewtopic.php?p=72299#72299)
> > > > 
> > > > 
> > > > 
> > > > 
> > >  
> > > 
> > > 
> > > > _______________________________________________
> > > > osg-users mailing list
> > > >  ()
> > > > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org (http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org)
> > > > 
> > >  
> >  
> > 
> >  (http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient) Virus-free. www.avg.com (http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient)      (#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2)
> > 
> > 
> > 
> > > Hi Julien,
> > > 
> > > Could you let me/us know to which mail you attached your modified 
> > > nathan? I can't find it. Can you let me/us know or send it directly?
> > > 
> > > Cheers
> > > Raymond
> > > 
> > > 
> > > 
> > > On 11/2/2017 7:30 PM, Julien Valentin wrote:
> > > 
> > > 
> > 0 
> 
> 
>  ------------------
> Post generated by Mail2Forum


------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=72361#72361