[osg-users] [osganimation branch] Review, test, critics

[Julien Valentin]

Hi
I'm a bit concerned about the nathan.osg compatibility with RigTransHW..
I attached in my last a modified version of nathan (without shared ss) that should work (and so would replace the current one in osgdata).

I would be glad if Raymond (or other) could validate this model (ideally under win32) with the following tests
softwaretest : osganimationviewer nathan2.osg 
HWtest:          osganimationhardware --number 1 nathan2.osg
(Don't forget I changed the maxnumbones type from int to uint in skinning.vert )
Once these tests validated elsewhere than my computer, It will confort me in the validity of the branch so i can make PRs to master (and to osgdata).  

Cheers


robertosfield wrote:
> Hi Raymond & Julien,
> 
> On 2 November 2017 at 14:17, Raymond de Vries < ()> wrote:
> 
> >  I have not seen any issues in our own use of the osgAnimation. We tested in a few different setups and all seems ok.
> > 
> > The only thing is that the example did not work for me with Visual Studio 2015, while it does work for Julien.
> > 
> 
> 
> Thanks for the testing.
> 
> 
> Julian, if you feel osganimation is now ready could you generate a PR for the branch and I'll go ahead and merge it.
> 
> 
> Cheers,
> Robert.
> 
>  
> 
>  ------------------
> Post generated by Mail2Forum


------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=72293#72293