<div dir="ltr"><div><div><div>Hi Laurens,<br><br></div>Grumble, grumble, grumble, I was really hoping 3.4.1 would be binary compatible with 3.4.0... grumble. Shame that the osgDB exports fix for VS breaks compatibility.<br><br></div>Rather than revert the fix I'll just bump the SO version to 131<br><br></div>Robert.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On 22 August 2017 at 13:44, Voerman, L. <span dir="ltr"><<a href="mailto:l.voerman@rug.nl" target="_blank">l.voerman@rug.nl</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Robert,<div><br><div>I found a binary incompatibility between osg130-osgDB.dll (osg 3.4.0) and osg130-osgDB.dll (osg 3.4.1)</div><div>I compile all on Windows 10 with Visual Studio 2015:</div><div><br></div><div>My binary (compiled against 3.4.0) won't work with 3.4.1 osg binary's due to missing functions in osgDB:</div><div><div>??_Difstream@osgDB@@QEAAXXZ</div><div>void osgDB::ifstream::`vbase destructor'(void)</div><div><br></div><div>??_Dofstream@osgDB@@QEAAXXZ</div><div>void osgDB::ofstream::`vbase destructor'(void)</div><div><br></div><div>?close@?$basic_ofstream@DU?$ch<wbr>ar_traits@D@std@@@std@@QEAAXXZ</div><div>void std::basic_ofstream<char,struc<wbr>t std::char_traits<char> >::close(void)</div></div><div><br></div><div>These are removed with PR Commits on Jul 27, 2017</div><div><a href="https://github.com/openscenegraph/OpenSceneGraph/commit/eabd08ef2544ac2d148ac6eddc2cb33e7025bd70" class="m_7647340826586153621m_-8042634902503360813gmail-message" title="Attempt to fix broken DLL exports from osgDB
Only export the osgDB method implementations, instead of the entire
class, and hence avoid exporting symbols from the base class, which
then conflict with other compilation units when linking.
This avoids the need for /FORCE:MULTIPLE linker option with MSVC." target="_blank">Attempt to fix broken DLL exports from osgDB</a></div><div><br></div><div><div class="m_7647340826586153621m_-8042634902503360813gmail-table-list-cell">
<div class="m_7647340826586153621m_-8042634902503360813gmail-commit-meta m_7647340826586153621m_-8042634902503360813gmail-commit-author-section">
<a href="https://github.com/openscenegraph/OpenSceneGraph/commits/OpenSceneGraph-3.4?author=zakalawe" class="m_7647340826586153621m_-8042634902503360813gmail-commit-author m_7647340826586153621m_-8042634902503360813gmail-tooltipped m_7647340826586153621m_-8042634902503360813gmail-tooltipped-s m_7647340826586153621m_-8042634902503360813gmail-user-mention" rel="contributor" target="_blank">zakalawe</a>
committed
with
<a href="https://github.com/openscenegraph/OpenSceneGraph/commits/OpenSceneGraph-3.4?author=robertosfield" class="m_7647340826586153621m_-8042634902503360813gmail-user-mention m_7647340826586153621m_-8042634902503360813gmail-commit-author m_7647340826586153621m_-8042634902503360813gmail-tooltipped m_7647340826586153621m_-8042634902503360813gmail-tooltipped-s" rel="contributor" target="_blank">robertosfield</a>
<span datetime="2016-08-05T12:16:07Z" title="Aug 5, 2016, 2:16 PM GMT+2">on Aug 5, 2016</span>
<span class="m_7647340826586153621m_-8042634902503360813gmail-commit-indicator">
<div class="m_7647340826586153621m_-8042634902503360813gmail-commit-build-statuses">
<a class="m_7647340826586153621m_-8042634902503360813gmail-text-red m_7647340826586153621m_-8042634902503360813gmail-tooltipped m_7647340826586153621m_-8042634902503360813gmail-tooltipped-e" href="https://travis-ci.org/openscenegraph/OpenSceneGraph/builds/258201300?utm_source=github_status&utm_medium=notification" target="_blank">
</a>
</div>
</span>
</div>
</div>
<div class="m_7647340826586153621m_-8042634902503360813gmail-commit-links-cell m_7647340826586153621m_-8042634902503360813gmail-table-list-cell">
<div class="m_7647340826586153621m_-8042634902503360813gmail-commit-links-group m_7647340826586153621m_-8042634902503360813gmail-BtnGroup">
</div></div>
<div class="m_7647340826586153621m_-8042634902503360813gmail-commit-links-group m_7647340826586153621m_-8042634902503360813gmail-BtnGroup"></div></div><div><br></div><div>traced this back to <a href="http://forum.openscenegraph.org/viewtopic.php?p=68432" target="_blank">this</a> mail thread - and found out that I am not the first to find out the incompatibility.</div><div><br></div><div>In order to keep the binary incompatible versions apart I would suggest increasing the SO number.</div><div>Regards, Laurens.</div></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Tue, Aug 22, 2017 at 1:24 PM, Robert Osfield <span dir="ltr"><<a href="mailto:robert.osfield@gmail.com" target="_blank">robert.osfield@gmail.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><div dir="ltr"><div>Hi All,<br><br></div>I have just tagged the 3.4.1 release candidate 2:<br><div><br> <a href="https://github.com/openscenegraph/OpenSceneGraph/tree/OpenSceneGraph-3.4.1-rc2" target="_blank">https://github.com/openscenegr<wbr>aph/OpenSceneGraph/tree/<wbr>OpenSceneGraph-3.4.1-rc2</a><br><br></div><div>A few build and bug fixes since rc1, please test, all going well we should be able to get the final 3.4.1 out this week.<br><br></div><div>Cheers,<br></div><div>Robert.<br></div><div><br><br></div><div>-- ChangeLog since 3.4.1-rc1 (28th July):<br><br>Tue, 22 Aug 2017 11:58:49 +0100<br>Checked in by : Robert Osfield<br>Added name typo fix<br><br>Tue, 22 Aug 2017 09:05:27 +0100<br>Checked in by : Robert Osfield<br>Updated ChangeLog<br><br>Tue, 22 Aug 2017 09:04:49 +0100<br>Checked in by : Robert Osfield<br>Added catch for controbutors list<br><br>Tue, 22 Aug 2017 08:03:33 +0100<br>Checked in by : OpenSceneGraph git repository<br>Merge pull request #310 from OpenMW/merge_internalsizedform<wbr>atsApplied sizedInternalFormats change to 3.4 branch<br><br>Thu, 31 Mar 2016 17:12:28 +0100<br>Checked in by : Robert Osfield<br>Reversed the order of some sizedInternalFormats enum entries to sync with the change in serach direction that was checked in as an earlier revision.<br><br>Mon, 21 Aug 2017 15:06:31 +0100<br>Checked in by : Robert Osfield<br>Added handling of CPACK and automatically generated package files<br><br>Fri, 18 Aug 2017 16:26:12 +0100<br>Checked in by : Robert Osfield<br>Removed unneccessary DrawArrays->setCount() that was causing a crash.<br><br>Fri, 18 Aug 2017 16:11:29 +0100<br>Checked in by : Robert Osfield<br>Merged addition of "" around variablesfrom master.<br><br>Fri, 18 Aug 2017 16:01:31 +0100<br>Checked in by : Raymond de Vries<br>Fix for better picking up 3rd party dependencies<br><br>Fri, 18 Aug 2017 08:08:28 +0100<br>Checked in by : Robert Osfield<br>Fixed iterator comparison.<br><br>Thu, 17 Aug 2017 08:53:58 +0100<br>Checked in by : Robert Osfield<br>Adopted OSG_GL*_FEATURES usage of 0 and 1 in place of false and true to avoid VisualStudio 2012 build issues<br><br>Tue, 15 Aug 2017 15:42:22 +0100<br>Checked in by : Uwe Woessner<br>Extension to the PLY plugin to read files with textures.<br><br>Mon, 31 Jul 2017 16:47:10 +0100<br>Checked in by : OpenSceneGraph git repository<br>Merge pull request #291 from eligovision/OpenSceneGraph-3.4<wbr>_animationosgAnimation: classes UpdateVec2fUniform and UpdateVec4fUniform added<br><br>Sun, 30 Jul 2017 20:00:12 +0300<br>Checked in by : konstantin.matveyev<br>[*] osgDB::OutputStream fix<br><br>Sun, 30 Jul 2017 19:55:56 +0300<br>Checked in by : konstantin.matveyev<br>[+] Two classes added: osgAnimation::UpdateVec2fUnifo<wbr>rm, osgAnimation::UpdateVec4fUnifo<wbr>rm<br><br>Mon, 31 Jul 2017 15:06:57 +0100<br>Checked in by : OpenSceneGraph git repository<br>Merge pull request #289 from eligovision/OpenSceneGraph-3.4<wbr>_appleIMAGEIO plugin tweak<br><br>Mon, 31 Jul 2017 15:05:26 +0100<br>Checked in by : OpenSceneGraph git repository<br>Merge pull request #290 from eligovision/OpenSceneGraph-3.4<wbr>_apple_iososgViewer::GraphicsW<wbr>indowIOS fixes<br><br>Sun, 30 Jul 2017 20:03:56 +0300<br>Checked in by : konstantin.matveyev<br>[*] imageio changed: more methods of storing image supported; tested on macOS (compatibility profile) and iOS(GLES2/3)<br><br>Sun, 30 Jul 2017 19:58:56 +0300<br>Checked in by : konstantin.matveyev<br>[*] osgViewer::GraphicsWindowIOS fixes<br><br>Mon, 31 Jul 2017 12:44:47 +0100<br>Checked in by : Robert Osfield<br>Fixed indectation<br><br>Mon, 31 Jul 2017 12:42:15 +0100<br>Checked in by : OpenSceneGraph git repository<br>Merge pull request #288 from eligovision/OpenSceneGraph-3.4<wbr>_pragmaticpragma(tic) shader composing fixes in the State<br><br>Mon, 31 Jul 2017 00:53:24 +0300<br>Checked in by : konstantin.matveyev<br>[**] pragma(tic) fix: 'defineMap.changed flag' condition changed in State::push/popDefineList<br><br><br></div></div>
<br></div></div>______________________________<wbr>_________________<br>
osg-users mailing list<br>
<a href="mailto:osg-users@lists.openscenegraph.org" target="_blank">osg-users@lists.openscenegraph<wbr>.org</a><br>
<a href="http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org" rel="noreferrer" target="_blank">http://lists.openscenegraph.or<wbr>g/listinfo.cgi/osg-users-opens<wbr>cenegraph.org</a><br>
<br></blockquote></div><br></div>
<br>______________________________<wbr>_________________<br>
osg-users mailing list<br>
<a href="mailto:osg-users@lists.openscenegraph.org">osg-users@lists.<wbr>openscenegraph.org</a><br>
<a href="http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org" rel="noreferrer" target="_blank">http://lists.openscenegraph.<wbr>org/listinfo.cgi/osg-users-<wbr>openscenegraph.org</a><br>
<br></blockquote></div><br></div>