<div dir="ltr"><div class="gmail_default" style="font-family:tahoma,sans-serif">Hi Robert,</div><div class="gmail_default" style="font-family:tahoma,sans-serif"><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">I've eventually tested the submission on my project and everything works as expected.</div><div class="gmail_default" style="font-family:tahoma,sans-serif">Big files are now written and read correctly. </div><div class="gmail_default" style="font-family:tahoma,sans-serif">Thank you,</div><div class="gmail_default" style="font-family:tahoma,sans-serif">Riccardo.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 19, 2017 at 6:44 PM, Riccardo Corsi <span dir="ltr"><<a href="mailto:riccardo.corsi@kairos3d.it" target="_blank">riccardo.corsi@kairos3d.it</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto">Hi Robert, <div dir="auto"><br><div dir="auto">this week I'm out of office, I'll give it a test as soon as I come back. </div><div dir="auto">Cheers, </div><span class="HOEnZb"><font color="#888888"><div dir="auto">Riccardo</div></font></span></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Jun 19, 2017 6:03 PM, "Robert Osfield" <<a href="mailto:robert.osfield@gmail.com" target="_blank">robert.osfield@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">HI Riccardo,<br>
<br>
On 14 June 2017 at 19:32, Robert Osfield <<a href="mailto:robert.osfield@gmail.com" target="_blank">robert.osfield@gmail.com</a>> wrote:<br>
> Thanks Riccardo. I'm just heading offline for the evening so will<br>
> have a look tomorrow.<br>
<br>
I finally got the chance to do a review and merge your PR. I made a<br>
couple of further commits, first changing the long long to uint64,<br>
then added an if (version) check to the writing to mirror what you<br>
added to the reading, to leave the door open to eventually allowing us<br>
to write files that are compatible with older OSG versions, finally I<br>
bumped the version number up to 149 to enable the feature. All these<br>
changes are now checked into git master.<br>
<br>
I have tested by writing a .osgb file prior to bumping the version<br>
number, then the same model after bumping the version number. Both<br>
versions load just fine with the recent file just a little larger<br>
indicating the 64bit sizes are being written and read correctly :-)<br>
<br>
Could you test things out to confirm everything works at your end.<br>
<br>
Cheers,<br>
Robert.<br>
______________________________<wbr>_________________<br>
osg-users mailing list<br>
<a href="mailto:osg-users@lists.openscenegraph.org" target="_blank">osg-users@lists.openscenegraph<wbr>.org</a><br>
<a href="http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org" rel="noreferrer" target="_blank">http://lists.openscenegraph.or<wbr>g/listinfo.cgi/osg-users-opens<wbr>cenegraph.org</a><br>
</blockquote></div></div>
</div></div></blockquote></div><br></div>