<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi Laurens,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Your changes to the src\osgViewer\GraphicsWindowWin32.cpp did not fix the narrowing warnings for me.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">I have attached my changes, which solves all warnings for this file for me.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Regards<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Björn<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> osg-users [mailto:osg-users-bounces@lists.openscenegraph.org]
<b>On Behalf Of </b>Voerman, L.<br>
<b>Sent:</b> Friday, June 3, 2016 11:07 AM<br>
<b>To:</b> OpenSceneGraph Users <osg-users@lists.openscenegraph.org><br>
<b>Subject:</b> Re: [osg-users] Preparing to make 3.5.3 dev release, please test<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">Hi all,<o:p></o:p></p>
</div>
<p class="MsoNormal">After updating to visual studio 2015 I fixed a few of those (minor) warnings,<o:p></o:p></p>
<div>
<p class="MsoNormal">attached are the modified versions I use for<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">src\osg\ShapeDrawable.cpp</span><o:p></o:p></p>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">src\osgViewer\GraphicsWindowWin32.cpp</span><o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">Regards, Laurens.</span><o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Fri, Jun 3, 2016 at 10:48 AM, Björn Blissing <<a href="mailto:bjorn.blissing@vti.se" target="_blank">bjorn.blissing@vti.se</a>> wrote:<o:p></o:p></p>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal">Hi,<br>
<br>
I compiled the latest master with Visual Studio 2015.<br>
<br>
I got a couple of warnings. First of all I got a ton of these, which all originates from the same origin:<br>
<br>
<br>
Code:<br>
<br>
...<br>
OpenSceneGraph\include\osg/OperationThread(80): warning C4589: Constructor of abstract class 'osg::Operation' ignores initializer for virtual base class 'osg::Referenced' (compiling source file D:\github\OpenSceneGraph\src\osg\AnimationPath.cpp)<br>
OpenSceneGraph\include\osg/OperationThread(80): note: virtual base classes are only initialized by the most-derived type (compiling source file D:\github\OpenSceneGraph\src\osg\AnimationPath.cpp)<br>
...<br>
<br>
<br>
<br>
<br>
And the same warnings for the following classes:<br>
<br>
<br>
Code:<br>
<br>
OpenSceneGraph\src\osgGA\CameraManipulator.cpp(24): warning C4589: Constructor of abstract class 'osgGA::CameraManipulator' ignores initializer for virtual base class 'osg::Callback'<br>
OpenSceneGraph\src\osgGA\CameraManipulator.cpp(24): note: virtual base classes are only initialized by the most-derived type<br>
OpenSceneGraph\src\osgGA\StandardManipulator.cpp(51): warning C4589: Constructor of abstract class 'osgGA::StandardManipulator' ignores initializer for virtual base class 'osg::Callback'<br>
OpenSceneGraph\src\osgGA\StandardManipulator.cpp(51): note: virtual base classes are only initialized by the most-derived type<br>
OpenSceneGraph\src\osgViewer\ViewerBase.cpp(44): warning C4589: Constructor of abstract class 'osgViewer::ViewerBase' ignores initializer for virtual base class 'osg::Object'<br>
OpenSceneGraph\src\osgViewer\ViewerBase.cpp(44): note: virtual base classes are only initialized by the most-derived type<br>
OpenSceneGraph\src\osgViewer\ViewerBase.cpp(50): warning C4589: Constructor of abstract class 'osgViewer::ViewerBase' ignores initializer for virtual base class 'osg::Object'<br>
OpenSceneGraph\src\osgViewer\ViewerBase.cpp(50): note: virtual base classes are only initialized by the most-derived type<br>
OpenSceneGraph\src\osgAnimation\AnimationManagerBase.cpp(65): warning C4589: Constructor of abstract class 'osgAnimation::AnimationManagerBase' ignores initializer for virtual base class 'osg::Callback'<br>
OpenSceneGraph\src\osgAnimation\AnimationManagerBase.cpp(65): note: virtual base classes are only initialized by the most-derived type<br>
<br>
<br>
<br>
<br>
The I get a couple of warnings due to osg::PI being used with floats:<br>
<br>
<br>
Code:<br>
<br>
OpenSceneGraph\src\osg\ShapeDrawable.cpp(311): warning C4305: 'initializing': truncation from 'double' to 'float'<br>
OpenSceneGraph\src\osg\ShapeDrawable.cpp(381): warning C4305: 'initializing': truncation from 'double' to 'float'<br>
OpenSceneGraph\src\osg\ShapeDrawable.cpp(669): warning C4305: '=': truncation from 'double' to 'float'<br>
OpenSceneGraph\src\osg\ShapeDrawable.cpp(776): warning C4305: '=': truncation from 'double' to 'float'<br>
OpenSceneGraph\src\osg\ShapeDrawable.cpp(1479): warning C4305: 'initializing': truncation from 'double' to 'float'<br>
OpenSceneGraph\src\osg\ShapeDrawable.cpp(1697): warning C4305: '=': truncation from 'double' to 'float'<br>
OpenSceneGraph\src\osg\ShapeDrawable.cpp(1783): warning C4305: '=': truncation from 'double' to 'float'<br>
<br>
<br>
<br>
<br>
<br>
Then some warnings about narrowing conversions:<br>
<br>
<br>
Code:<br>
OpenSceneGraph\src\osgViewer\GraphicsWindowWin32.cpp(1693): warning C4838: conversion from 'int' to 'DWORD' requires a narrowing conversion<br>
OpenSceneGraph\src\osgViewer\GraphicsWindowWin32.cpp(1693): warning C4838: conversion from 'unsigned int' to 'BYTE' requires a narrowing conversion<br>
<br>
<br>
<br>
And finally some shadowed variable warnings:<br>
<br>
<br>
Code:<br>
OpenSceneGraph\src\osgShadow\ConvexPolyhedron.cpp(820): warning C4459: declaration of 'Points' hides global declaration<br>
OpenSceneGraph\src\osgShadow\ConvexPolyhedron.cpp(88): note: see declaration of '`anonymous-namespace'::Points'<br>
OpenSceneGraph\src\osgViewer\GraphicsWindowWin32.cpp(2739): warning C4457: declaration of 'lParam' hides function parameter<br>
OpenSceneGraph\src\osgViewer\GraphicsWindowWin32.cpp(2511): note: see declaration of 'lParam'<br>
<br>
<br>
<br>
There was also a lot of (+100) shadow warnings in the 3ds library. As well as one shadow warning each for the fbx and txp library.<br>
<br>
Regards<br>
<br>
Björn<br>
<br>
------------------<br>
Read this topic online here:<br>
<a href="http://forum.openscenegraph.org/viewtopic.php?p=67374#67374" target="_blank">http://forum.openscenegraph.org/viewtopic.php?p=67374#67374</a><o:p></o:p></p>
<div>
<div>
<p class="MsoNormal"><br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
osg-users mailing list<br>
<a href="mailto:osg-users@lists.openscenegraph.org">osg-users@lists.openscenegraph.org</a><br>
<a href="http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org" target="_blank">http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org</a><o:p></o:p></p>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</div>
</body>
</html>