[osg-users] Please test OpenSceneGraph-3.6

[Daniel Emminizer, Code 5773]

Hi Robert,

Seems like a reasonable approach.  I'll rebuild on my side when you think you have something good.

 - Dan



> -----Original Message-----
> From: osg-users [mailto:osg-users-bounces at lists.openscenegraph.org] On
> Behalf Of Robert Osfield
> Sent: Monday, May 21, 2018 7:27 AM
> To: OpenSceneGraph Users
> Subject: Re: [osg-users] Please test OpenSceneGraph-3.6
> 
> Hi Dan,
> 
> 
> Two steps forward, one step back....
> 
> For compatibility between various versions of the OSG and osgQt I am
> inclined to change the REGISTER_WINDOWINGSYSTEMINTERFACE
> implementation back to what it was and either introduce a new macro
> that adds the OSGVIEWER_EXPORT or  just have the
> GraphicsWindowWin32.cpp not use the this help marco at all, and just
> have it declare the extern and proxy objects directly in the code.
> 
> 
> Robert.
> 
> 
> On 21 May 2018 at 11:48, Daniel Emminizer, Code 5773
> <dan.emminizer at nrl.navy.mil> wrote:
> > Hi Robert,
> >
> > Getting a Windows build error on osgQt from the change on
> REGISTER_WINDOWINGSYSTEMINTERFACE() macro from last week.  Are you
> the right person to report the problem to?
> >
> > osgQt's GraphicsWindowQt.cpp includes the line:
> >
> >   #if 1
> >   REGISTER_WINDOWINGSYSTEMINTERFACE(Qt, QtWindowingSystem)
> >   ...
> >
> > With the change to the macro, it expands to:
> >   extern "C" OSGVIEWER_EXPORT void graphicswindow_qt(void) {} ....
> >
> > where OSGVIEWER_EXPORT is defined as "__declspec(dllimport)"
> (because we're now in osgQt and not osgViewer)
> >
> >
> > One possible fix is to add a parameter to
> REGISTER_WINDOWINGSYSTEMINTERFACE to specify the export flavor, such
> as:
> >
> >   #define REGISTER_WINDOWINGSYSTEMINTERFACE(export_type, ext,
> classname) \
> >     extern "C export_type void ...
> >
> >   REGISTER_WINDOWINGSYSTEMINTERFACE(OSGQT_EXPORT, Qt,
> QtWindowingSystem)
> >
> > Of course the down-side is that it would change the interface to the macro;
> but that seems better than the alternative of breaking on Windows.  I'm
> happy to test if you need.
> >
> >  - Dan
> >
> >
> >> -----Original Message-----
> >> From: osg-users [mailto:osg-users-bounces at lists.openscenegraph.org]
> On
> >> Behalf Of Robert Osfield
> >> Sent: Friday, May 18, 2018 10:49 AM
> >> To: OpenSceneGraph Users
> >> Subject: [osg-users] Please test OpenSceneGraph-3.6
> >>
> >> Hi All,
> >>
> >> I have checked in a few fixes today, one of them I'm not confident
> >> that it'll work across all platforms so I won't make 3.6.1-rc5 today,
> >> instead I'll wait for feedback from the community.
> >>
> >> As usual please let us know via this thread about success or failures.
> >>
> >> Thanks for the testing,
> >> Robert.
> >>
> >
> > _______________________________________________
> > osg-users mailing list
> > osg-users at lists.openscenegraph.org
> > http://lists.openscenegraph.org/listinfo.cgi/osg-users-
> openscenegraph.org
> _______________________________________________
> osg-users mailing list
> osg-users at lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org