[osg-users] Bug in Cull Visitor

[Robert Osfield]

Hi Gedalia,

Well spotted, this issue has been in the code for almost two decades
without anyone noticing.  I've removed the duplicate from CullVisitor
and checked this into OSG master and the 3.6 branch.

Robert.

On 12 May 2018 at 21:34, Gedalia Pasternak <gpasternak at mak.com> wrote:
> Both CullVisitor and it's base class NodeVisitor have members named
> _traversalNumber. Yielding duplicate member variables with the same name,
> and inconsistent behavior depending on how you access the class.
> Cull visitor's should be renamed, maybe to _cullTraversalNumber or something
> that wouldn't conflict with the base class. An accessor would be nice as
> well. In the case of NodeVisitor it's what frame it's up to, for cull
> visitor it's what accepted object it's up to (
>    // Otherwise need to create new renderleaf.
>     RenderLeaf* renderleaf = new
> RenderLeaf(drawable,projection,matrix,depth,_traversalNumber++);
> )
>
> -Gedalia
>
> _______________________________________________
> osg-users mailing list
> osg-users at lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>