[osg-users] VBO Bug with 3.6.1 and Normal Arrays

[Daniel Emminizer, Code 5773]

Hi Robert,

I agree that your solution here seems to cover the common failure case (assigning by-vertex too late).  I think given the system constraints and time constraints, that is the best solution.

Your solution does work in all my testing.

Regarding a 3.6.2 release, that sounds great.  At this point we've upgraded almost all of our applications and this was the last major issue we had.  We've still got one minor text output annoyance, and I'll start a new thread on that once I track it down if it's a change in OSG causing it.  I'll do that in the next couple of days here.

Thanks,

 - Dan



> -----Original Message-----
> From: osg-users [mailto:osg-users-bounces at lists.openscenegraph.org] On
> Behalf Of Robert Osfield
> Sent: Thursday, June 14, 2018 4:10 AM
> To: OpenSceneGraph Users
> Subject: Re: [osg-users] VBO Bug with 3.6.1 and Normal Arrays
> 
> H Dan et. al,
> 
> On Thu, 14 Jun 2018 at 08:25, Robert Osfield <robert.osfield at gmail.com>
> wrote:
> > Perhaps another approach would be to just warn the user that the
> > Binding hasn't been set prior to the Geometry::set*Array() call, or do
> > a belt and braces of treat an BIND_UNDEFINED binding as a
> > BIND_PER_VERTEX to force a VertexBufferObject to be assign
> > automatically even though it might not be needed.  This might waste a
> > byte or two but would probably be safe.
> 
> This is the approach I have taken, it fixes the test program when
> VAO's are used and the array::setBinding(..) is called after the
> Geometry::set*Array() call.
> 
> 
> https://github.com/openscenegraph/OpenSceneGraph/commit/4665a2f033
> 68be95f4773463f733dbdd88f63c5f
> 
> I think it's the safest and least intrusive way to catch late calls to
> setBinding(..).
> 
> Could you all test the OpenSceneGraph-3.6 head and if this works fine
> we can start thinking about going for 3.6.2.
> 
> Robert.
> _______________________________________________
> osg-users mailing list
> osg-users at lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org