[osg-users] osgDB XmlParser and localization

[Trajce Nikolov NICK]

Thanks so much Robert !!! Attached is the file



On Mon, Jul 9, 2018 at 1:50 PM Robert Osfield <robert.osfield at gmail.com>
wrote:

> Hi Nick,
>
> On Mon, 9 Jul 2018 at 12:26, Trajce Nikolov NICK
> <trajce.nikolov.nick at gmail.com> wrote:
> > >  .... are changes for changes sake rather than likely to make any
> > functional difference
> >
> > I knew you will have comments ;-). It works just fine with these changes
> but yes, you are right - quick and somewhat dirty. So can you look at it or
> you want to do a ping-pong code review with my changes by your advice? :-)
>
> I might be quicker just to provide a link to or attach an xml file
> that causes problem with the present parser, and then I can look at
> what happens when the present code encounters it, and how your changes
> affect things.
>
> As a general note, PRs/commits should be focused on addressing one
> issue at a time, so bundling a fix for a specific bug along with other
> cosmetic or other changes just confuses what is functional and what is
> not.  It's not uncommon to have to go back to various revisions in
> code to see where regressions may have occurred so having commits that
> just wrap up a small set of associated changes is really helpful in
> identifying what has been changed and why.
>
> Robert.
> _______________________________________________
> osg-users mailing list
> osg-users at lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>


-- 
trajce nikolov nick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openscenegraph.org/pipermail/osg-users-openscenegraph.org/attachments/20180709/7dd727a6/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: map.osm
Type: application/octet-stream
Size: 947036 bytes
Desc: not available
URL: <http://lists.openscenegraph.org/pipermail/osg-users-openscenegraph.org/attachments/20180709/7dd727a6/attachment-0001.obj>