[osg-users] minor change: move assumeSizedInternallFormat from Texture to Image

Robert Osfield robert.osfield at gmail.com
Thu Aug 16 00:47:02 PDT 2018

Hi Julien,

On Wed, 15 Aug 2018 at 23:44, Julien Valentin
<julienvalentin51 at gmail.com> wrote:
> if I read all that correctly it seams assumeSizedInternallFormat is only used to create Texture from Image...I think an improvment would be to move assumeSizedInternallFormat from Texture to Image and change its name (getSizedTexInternallFormat).. It would lever some confusion and improve readabitlity of the Texture.cpp code ....
> What od you think about that?

This is what I was roughly thinking of.  One can't move the function
from Texture to Image as not all textures have images.  You could have
it in both places, or just have a function in the osg namespace and
provide all the input variables for it.

As a general guide, a Object::getMethod() typically gets a property
from an object, but if a method computes the value on the fly from
input variables I nornally opt for Object::computeMethod().   assume
is a bit wishy washy so probably isn't ideal - this was used in the
original glTexStorage PR but I probably should have suggested a

We have to think about both master and the 3.6 branch here.  The later
the aim is to maintain binary compatibility so our options are more


More information about the osg-users mailing list