[osg-users] Minor change proposal : Blacklist usage of all unsized texture internat format

Robert Osfield robert.osfield at gmail.com
Tue Aug 14 10:02:16 PDT 2018


HI Julien,

On Tue, 14 Aug 2018 at 17:24, Julien Valentin
<julienvalentin51 at gmail.com> wrote:
> So if noone have a better idea, my proposal is to simply to ban usage unsized _internalFormats. I think it would sanitize osg

I have already rejected that idea.

Your changes to use glTextureStorage in master have broken the OSG for
existing users as reported elsewhere.  I don't think it's acceptable.
Your changes have introduced a regression and we need to fix this, not
push the blame for this regression onto users for not explicitly
setting the internal format where applications were perfectly OK
previously.

You need to start thinking about backwards compatibility.

If glTextureStorage adds a requirement that the internal format is set
then perhaps we should just disable it's use when the internal format
is not set and just rely upon glTextureStorage when it is.  This way
original usage will use the original code paths and not break
anything.

Robert.


More information about the osg-users mailing list