[osg-users] New glTexStorage code is disrupting FBO initialization

[Julien Valentin]

@Robert
As you see I removed some call to setSourceFormat
This is because i made sourceformat more prioritized than internal format in my glTexStorageXD calls it surely be wiser to remove this priority scheme (only when texstorage available) and don't remove call to setSourceFormat


mp3butcher wrote:
> All is linked:
> in osgdeffered:
> remove l.51
> //  tex2D->setSourceFormat(GL_RGBA);
> in osgssbo l.802
>     texture->setInternalFormat(GL_RGBA16);
> osgoit : DpethPeeling.cpp 
> remove l310      
>   colorTexture->setInternalFormat(GL_RGBA16);
> and that's all
> (I haven't made pr for them)
> 
> 
> Paul Levy wrote:
> > Julien,
> > 
> > Thanks for looking into it.  I think there is a different problem as Glenn mentioned.  All the examples that use COLOR_BUFFER0 are broken on my system.  osgdeferred, osgSSBO, osgoit, etc are a few I tried.  Setting 
> > OSG_GL_TEXTURE_STORAGE=OFF fixes the problem but as Glenn mentioned, COLOR_BUFFER0 has worked in the past prior to texture storage.
> > 
> > 
> > Thank you--
> > Paul Levy : Pelican Mapping
> > 
> > 
> > 
> > 
> > 
> > On Fri, Aug 10, 2018 at 3:16 PM Julien Valentin < ()> wrote:
> > 
> > 
> > > I debugged osgprerender
> > > It was the unsized texture format:
> > > changing GL_RGBA to GL_RGBA8
> > > i'll patch the example
> > > but you have to patch osgearth
> > > 
> > > 
> > > gwaldron wrote:
> > > 
> > > > Julian,New information: In osgEarth we use Camera::attach like so:
> > > > 
> > > > 
> > > >    rttCamera->attach(osg::Camera::COLOR_BUFFER0, texture);
> > > > 
> > > > 
> > > > If I replace COLOR_BUFFER0 with COLOR_BUFFER, it works. Been using the former since forever but maybe it was wrong.
> > > > 
> > > > 
> > > > Glenn Waldron
> > > > 
> > > > 
> > > > 
> > > > 
> > > > 
> > > > 
> > > > 
> > > > 
> > > > On Fri, Aug 10, 2018 at 12:39 PM Julien Valentin < ()> wrote:
> > > > 
> > > > 
> > > > 
> > > > > Hi
> > > > > It's weird that immutable texture interact with fbo render to texture.
> > > > > I've done a lot of FBORTT since this commit and haven't seen any problem
> > > > > Are you sure your problem come from here?
> > > > > Try to replicate the behavior in a simple example code please
> > > > > 
> > > > > Cheers
> > > > > 
> > > > > 
> > > > > gwaldron wrote:
> > > > > 
> > > > > 
> > > > > > Robert,
> > > > > > 
> > > > > > 
> > > > > > We recently pulled the latest master branch of OpenSceneGraph, and found that FBOs in osgEarth no longer initialize properly. We narrowed the problem down to this commit which appears to introduce the usage of glTexStorage:
> > > > > > 
> > > > > > 
> > > > > > https://github.com/openscenegraph/OpenSceneGraph/commit/7be09e8dcd1ed63eb501c12bb7c8df6f6902783b (https://github.com/openscenegraph/OpenSceneGraph/commit/7be09e8dcd1ed63eb501c12bb7c8df6f6902783b) (https://github.com/openscenegraph/OpenSceneGraph/commit/7be09e8dcd1ed63eb501c12bb7c8df6f6902783b (https://github.com/openscenegraph/OpenSceneGraph/commit/7be09e8dcd1ed63eb501c12bb7c8df6f6902783b)) (https://github.com/openscenegraph/OpenSceneGraph/commit/7be09e8dcd1ed63eb501c12bb7c8df6f6902783b (https://github.com/openscenegraph/OpenSceneGraph/commit/7be09e8dcd1ed63eb501c12bb7c8df6f6902783b) (https://github.com/openscenegraph/OpenSceneGraph/commit/7be09e8dcd1ed63eb501c12bb7c8df6f6902783b (https://github.com/openscenegraph/OpenSceneGraph/commit/7be09e8dcd1ed63eb501c12bb7c8df6f6902783b)))
> > > > > > 
> > > > > > 
> > > > > > We are seeing output like the following. 
> > > > > > 
> > > > > > 
> > > > > > RenderStage::runCameraSetUp(), FBO setup failed, FBO status= 0x8cd6
> > > > > > 
> > > > > > Warning: RenderStage::runCameraSetUp(State&) Pbuffer does not support multiple color outputs.
> > > > > > ContextData::incrementContextIDUsageCount(0) to 2
> > > > > > Warning: detected OpenGL error 'invalid enumerant' after applying attribute Viewport 000002517C076560
> > > > > > RenderStage::runCameraSetUp(), FBO setup failed, FBO status= 0x8cd6
> > > > > > Warning: RenderStage::runCameraSetUp(State&) Pbuffer does not support multiple color outputs.
> > > > > > ContextData::incrementContextIDUsageCount(0) to 3
> > > > > > 
> > > > > > 
> > > > > > The "osgprerender" example still seems to work but generates FBO warnings as well.  I have not had a chance for a deep-dive yet ... but wanted to make you aware.
> > > > > > 
> > > > > > 
> > > > > > Glenn Waldron / osgEarth
> > > > > > 
> > > > > >   ------------------
> > > > > > Post generated by Mail2Forum
> > > > > > 
> > > > > > 
> > > > > 
> > > > > 
> > > > > ------------------------
> > > > > Twirling twirling twirling toward freedom
> > > > > 
> > > > > ------------------
> > > > > Read this topic online here:
> > > > > http://forum.openscenegraph.org/viewtopic.php?p=74485#74485 (http://forum.openscenegraph.org/viewtopic.php?p=74485#74485) (http://forum.openscenegraph.org/viewtopic.php?p=74485#74485 (http://forum.openscenegraph.org/viewtopic.php?p=74485#74485))
> > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > > _______________________________________________
> > > > > osg-users mailing list
> > > > >   ()
> > > > > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org (http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org) (http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org (http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org))
> > > > > 
> > > > > 
> > > > 
> > > > 
> > > >   ------------------
> > > > Post generated by Mail2Forum
> > > > 
> > > 
> > > 
> > > ------------------------
> > > Twirling twirling twirling toward freedom
> > > 
> > > ------------------
> > > Read this topic online here:
> > > http://forum.openscenegraph.org/viewtopic.php?p=74489#74489 (http://forum.openscenegraph.org/viewtopic.php?p=74489#74489)
> > > 
> > > 
> > > 
> > > 
> > > 
> > > _______________________________________________
> > > osg-users mailing list
> > >  ()
> > > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org (http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org)
> > > 
> > 
> > 
> >  ------------------
> > Post generated by Mail2Forum
> 


------------------------
Twirling twirling twirling toward freedom

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=74492#74492