[osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Robert Osfield]

Hi Stuart,

On 12 May 2017 at 14:32, Stuart Mentzer <Stuart_Mentzer at objexx.com> wrote:
> I always build from scratch in an empty build directory.

Thanks for the clarification.

> Adding " around the 3rd and 4th args in the REPLACE lines did indeed
> eliminate the error. Torben should check that this is still OK when the
> Collada plugin is in use.

I'm currently looking at the changes and the error report, trying to
make sense of what is the root of the issue and how to resolve it.
Unfortunately I haven't heard from Torben yet so don't yet know what
his thoughts are.  Form what I understand Torben introduced the
COLLADA_BOOST_BUILDNAME to cope with variations under Windows related
to the platform tools set, hence the introduction of the
CMAKE_VS_PLATFORM_TOOLSET in the lines like:


ELSEIF(MSVC14)
    SET(COLLADA_BUILDNAME "vc14")
    string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC12)
    SET(COLLADA_BUILDNAME "vc12")
    string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC11)
    SET(COLLADA_BUILDNAME "vc11")
    string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC10)
    SET(COLLADA_BUILDNAME "vc10")
    string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC90)
    SET(COLLADA_BUILDNAME "vc9")
    string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC80)
    SET(COLLADA_BUILDNAME "vc8")
    string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSE(APPLE)

CMaker docs for the CMAKE_VS_PLATFORM_TOOLSET} are:

    https://cmake.org/cmake/help/v3.0/variable/CMAKE_VS_PLATFORM_TOOLSET.html

Which mentons that it's set for VC10 and above.  Torben uses the
CMAKE_VS_PLATFORM_TOOLSET for vc8 and vc9 above, so I'm not what would
happen here.

What VC number is reported on your system?

> [Separate issue: curl 7.54.0 (latest) has a build error under VC++ 2015 but
> the prev version builds OK]

Is this a build error in curl, or the OSG plugin building against curl 7.54.0?

Thanks,
Robert.