[osg-users] [osgPlugins] build osg 3.5.4 plugin lua error, on vs 2010

[Robert Osfield]

Thanks Rene, fix now checked into OSG git master.

On 5 October 2016 at 14:54, René Molenaar <megamillerzoid at gmail.com> wrote:
> Yes,
> the additional memcpy, is the old code,
> (just in case i added updated/fixed version).
>
> gr.
> René
>
>
> 2016-10-05 13:57 GMT+02:00 Robert Osfield <robert.osfield at gmail.com>:
>>
>> Hi Rene,
>>
>> Thanks for the fix.  I've just compared to master version of lstring.c
>> against your modification version and there are two difference, first
>> the declaration of the start_of_string local variable at the top of
>> the function while resolves the compile issue, and second a memcpy
>> addition prior to the assingment to start_of_string.  This second
>> addition looks like it's been pulled in from the 3.4 branch.
>>
>> Robert,
>>
>> On 5 October 2016 at 12:27, René Molenaar <megamillerzoid at gmail.com>
>> wrote:
>> > Hi all,
>> >
>> > i ran into the same problem (when compiling in vs2012), see this
>> > changeset:
>> >
>> > https://github.com/openscenegraph/OpenSceneGraph/commit/e64e70870d51873621be4f90f1301640d882704d
>> >
>> > char* start_of_string;
>> >
>> > this is caused by the fact that the file is c code, not c++ and the new
>> > variable needs to be declared at the start of the block.
>> >
>> > (updated file is attached)
>> >
>> > groetjes,
>> > René
>> >
>> >
>> > 2016-08-08 9:11 GMT+02:00 nguyen duy nam <osgforum at tevs.eu>:
>> >>
>> >> Hi, help me
>> >> log error
>> >>  All outputs are up-to-date.
>> >> 3>  lstring.c
>> >>
>> >>
>> >> 3>..\..\..\..\..\sources\openscenegraph3.5.0\src\osgPlugins\lua\lua-5.2.3\src\lstring.c(107):
>> >> error C2143: syntax error : missing ';' before 'type'
>> >>
>> >>
>> >> 3>..\..\..\..\..\sources\openscenegraph3.5.0\src\osgPlugins\lua\lua-5.2.3\src\lstring.c(108):
>> >> error C2065: 'start_of_string' : undeclared identifier
>> >>
>> >>
>> >> 3>..\..\..\..\..\sources\openscenegraph3.5.0\src\osgPlugins\lua\lua-5.2.3\src\lstring.c(108):
>> >> warning C4022: 'memcpy' : pointer mismatch for actual parameter 1
>> >>
>> >>
>> >> 3>..\..\..\..\..\sources\openscenegraph3.5.0\src\osgPlugins\lua\lua-5.2.3\src\lstring.c(109):
>> >> error C2065: 'start_of_string' : undeclared identifier
>> >>
>> >>
>> >> 3>..\..\..\..\..\sources\openscenegraph3.5.0\src\osgPlugins\lua\lua-5.2.3\src\lstring.c(109):
>> >> error C2109: subscript requires array or pointer type
>> >>
>> >>
>> >> 3>..\..\..\..\..\sources\openscenegraph3.5.0\src\osgPlugins\lua\lua-5.2.3\src\lstring.c(117):
>> >> error C2143: syntax error : missing '{' before '*'
>> >>
>> >>
>> >> 3>..\..\..\..\..\sources\openscenegraph3.5.0\src\osgPlugins\lua\lua-5.2.3\src\lstring.c(118):
>> >> warning C4431: missing type specifier - int assumed. Note: C no longer
>> >> supports default-int
>> >>
>> >>
>> >> 3>..\..\..\..\..\sources\openscenegraph3.5.0\src\osgPlugins\lua\lua-5.2.3\src\lstring.c(127):
>> >> warning C4133: 'return' : incompatible types - from 'TString *' to 'int
>> >> *'
>> >>
>> >>
>> >> 3>..\..\..\..\..\sources\openscenegraph3.5.0\src\osgPlugins\lua\lua-5.2.3\src\lstring.c(150):
>> >> warning C4133: 'return' : incompatible types - from 'int *' to 'TString
>> >> *'
>> >> 3>
>> >> ...
>> >> anyone show me, how to fix.
>> >> Thank you!
>> >>
>> >> Cheers,
>> >> nguyen
>> >>
>> >> ------------------
>> >> Read this topic online here:
>> >> http://forum.openscenegraph.org/viewtopic.php?p=68301#68301
>> >>
>> >>
>> >>
>> >>
>> >>
>> >> _______________________________________________
>> >> osg-users mailing list
>> >> osg-users at lists.openscenegraph.org
>> >>
>> >> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>> >
>> >
>> >
>> > _______________________________________________
>> > osg-users mailing list
>> > osg-users at lists.openscenegraph.org
>> >
>> > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>> >
>> _______________________________________________
>> osg-users mailing list
>> osg-users at lists.openscenegraph.org
>> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
>
>
> _______________________________________________
> osg-users mailing list
> osg-users at lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>