[osg-users] OpenThreads build error (OSG 3.4.0)

[Rick Irons]

Hi,

Our internal development environment was just recently updated and we are now encountering an OpenThreads build error on Windows with OSG 3.4.0.  The build error is included in the following Visual Studios 2013 build output...

1>------ Rebuild All started: Project: OpenThreads, Configuration: Debug x64 ------
2>------ Skipped Rebuild All: Project: uninstall, Configuration: Debug x64 ------
2>Project not selected to build for this solution configuration
1>  WIN32Condition.cpp
1>c:\program files (x86)\windows kits\8.1\include\shared\sdkddkver.h(272): fatal error C1189: #error :  _WIN32_WINNT settings conflicts with _WIN32_IE setting
1>  Win32Mutex.cpp
1>c:\program files (x86)\windows kits\8.1\include\shared\sdkddkver.h(272): fatal error C1189: #error :  _WIN32_WINNT settings conflicts with _WIN32_IE setting
1>  Win32Thread.cpp
1>c:\program files (x86)\windows kits\8.1\include\shared\sdkddkver.h(272): fatal error C1189: #error :  _WIN32_WINNT settings conflicts with _WIN32_IE setting
1>  Win32ThreadBarrier.cpp
1>  Version.cpp
1>  Atomic.cpp
1>c:\program files (x86)\windows kits\8.1\include\shared\sdkddkver.h(272): fatal error C1189: #error :  _WIN32_WINNT settings conflicts with _WIN32_IE setting
1>  Generating Code...
3>------ Rebuild All started: Project: osg, Configuration: Debug x64 ------
3>  AlphaFunc.cpp
3>  AnimationPath.cpp
3>  ApplicationUsage.cpp
3>  ArgumentParser.cpp

The source of the issue appears to be the following line in sdkddkver.h....

#if ((_WIN32_WINNT < _WIN32_WINNT_WIN2K) && (_WIN32_IE > _WIN32_IE_IE60SP1))

...where WIN32_WINNT is 0x0400 (per Open Thread definition<https://github.com/openscenegraph/OpenSceneGraph/blob/master/src/OpenThreads/win32/CMakeLists.txt>), WIN32_WINNT_WIN2K is 0x0500<https://msdn.microsoft.com/en-us/library/6sehtctf.aspx>, WIN32_IE is 0x0700 (new default in our dev environment), and WIN32_IE_IE60SP1 is 0x0601<https://msdn.microsoft.com/en-us/library/windows/desktop/aa383745(v=vs.85).aspx>.  What appears to now be tripping the error is that the default value of WIN32_IE has changed in our dev environment from 0x0600 to 0x0700.

I am interested in feedback regarding how to properly address this issue.  Possible options include...


1.)    Changing WIN32_WINNT to 0x0500 in the Open Thread cmake list file<https://github.com/openscenegraph/OpenSceneGraph/blob/master/src/OpenThreads/win32/CMakeLists.txt>.



2.)    Define WIN32_IE to 0x0600 in the Open Thread cmake list file<https://github.com/openscenegraph/OpenSceneGraph/blob/master/src/OpenThreads/win32/CMakeLists.txt>.

Thank you.

Rick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openscenegraph.org/pipermail/osg-users-openscenegraph.org/attachments/20160617/c8b00cc4/attachment-0002.htm>