[osg-users] Preparing to make 3.5.3 dev release, please test

[l.voerman]

Hi Robert,

I've just created a LaurensVoerman account on github and cloned the osg 
repro there.

That would probably have been a better starting point than a direct 
local clone.
still struggling with git.

Regards, Laurens.


On 6/6/2016 6:43 PM, Robert Osfield wrote:
> Hi Laurens,
>
> Do you have a githib account that you'd like me to credit with this
> submissions?  Where possible I've been utilizing the git commit
> --author feature where I have the email address used on github.
>
> Robert.
>
> On 6 June 2016 at 15:21, Voerman, L. <l.voerman at rug.nl> wrote:
>> Hi Robbert, Björn,
>> as I am updating to visual studio 2015 too, I added the new FBX sdk for
>> 2015, and get a single warning:
>>
>> 54>OpenSceneGraph\src\osgPlugins\fbx\WriterCompareTriangle.cpp(23): warning
>> C4456: declaration of 'g' hides previous local declaration
>> 54>  OpenSceneGraph\src\osgPlugins\fbx\WriterCompareTriangle.cpp(14): note:
>> see declaration of 'g'
>>
>> attached are a fix for the warning and an update for the FindFBX.cmake to
>> find the new SDK for windows.
>> Regards, Laurens.
>>
>> On Mon, Jun 6, 2016 at 3:41 PM, Robert Osfield <robert.osfield at gmail.com>
>> wrote:
>>> Hi Björn,
>>>
>>> On 6 June 2016 at 13:55, Björn Blissing <bjorn.blissing at vti.se> wrote:
>>>> In the LUA-plugin:
>>>>
>>>>
>>>> Code:
>>>>
>>>>
>>>> d:\code\github\openscenegraph\src\osgplugins\lua\lua-5.2.3\src\lapi.c(1110):
>>>> warning C4702: unreachable code
>>> Removing the return statement that the warning is complaining about
>>> would force a in the break method API.  Could be a slippery slope of
>>> changes required so I've just disabled the warning, at least tried to
>>> using simple CMake entry to what you added to the 3ds plugin.
>>>
>>>> In the OSC-plugin:
>>>>
>>>>
>>>> Code:
>>>> openscenegraph\src\osgPlugins\osc\ip\win32\NetworkingUtils.cpp(80):
>>>> warning C4996: 'gethostbyname': Use getaddrinfo() or GetAddrInfoW() instead
>>>> or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings
>>>>    C:\Program Files (x86)\Windows Kits\8.1\Include\um\winsock2.h(2238):
>>>> note: see declaration of 'gethostbyname'
>>>> openscenegraph\src\osgPlugins\osc\ip\win32\UdpSocket.cpp(401): warning
>>>> C4456: declaration of 'currentTimeMs' hides previous local declaration
>>>>    openscenegraph\src\osgPlugins\osc\ip\win32\UdpSocket.cpp(386): note:
>>>> see declaration of 'currentTimeMs'
>>>>
>>>> The first one is self explainatory. The second one is a simple variable
>>>> shadowing. Which I do not think have any unintended consequences.
>>> This is 3rd party code that's integrated, we could fix or just disable
>>> the warnings.  If we modify the code we'd need to test it to make
>>> sure.  I'm not the original author of the code or a Windows hack so
>>> I'll not personally dive in and start hacking with the code.  If no
>>> one else feels the urge then I'd suggest we just disable the warning.
>>>
>>> The shadowing warning I've simply removed the second double as it's not
>>> needed.
>>>
>>>
>>>> In the OSG-plugin:
>>>>
>>>>
>>>> Code:
>>>> openscenegraph\src\osgPlugins\osg\ReaderWriterOSG.cpp(257): warning
>>>> C4459: declaration of 'NodeList' hides global declaration
>>>>    openscenegraph\include\osg/Group(22): note: see declaration of
>>>> 'osg::NodeList'
>>> I've changed the code to simply use the osg::NodeList variant.
>>>
>>>
>>>> And finally in the TXP plugin:
>>>>
>>>> Code:
>>>> openscenegraph\src\osgPlugins\txp\trpage_pparse.cpp(241): warning C4458:
>>>> declaration of 'imageHelp' hides class member
>>>>    openscenegraph\src\osgPlugins\txp\trpage_print.h(136): note: see
>>>> declaration of 'trpgPrintGraphParser::imageHelp'
>>>>
>>>> This last one may actually have consequences which the author did not
>>>> intend. But I am entirely not sure. The author have a protected member
>>>> variable named imageHelp, which is set in the constructor. It also have an
>>>> access method. But the variable is not used anywhere inside of the class,
>>>> instead the scoped variable with the same name is used.
>>> I've changed the local name to parse_imageHelp to make sure it's using
>>> the local one.
>>>
>>> With these fixes now checked into master it should just be the OSC warning
>>> left.
>>>
>>> Robert.
>>> _______________________________________________
>>> osg-users mailing list
>>> osg-users at lists.openscenegraph.org
>>> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>>
>>
>> _______________________________________________
>> osg-users mailing list
>> osg-users at lists.openscenegraph.org
>> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>>
> _______________________________________________
> osg-users mailing list
> osg-users at lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org