[osg-users] Preparing to make 3.5.3 dev release, please test

[Björn Blissing]

The included CMakeLists file is for the 3ds plugin.

My suggestion is to disable the variable shadowing warnings for this project, since it is basically an external library although included as source files. The other option is to fix all the variable name reuse for that project, which feels kind of unnecessary as lib3ds is pretty much abandoned as project (no activity since 2013). Autodesk has also stopped their development of this format years ago.

Regards
Björn

________________________________________
Från: osg-users <osg-users-bounces at lists.openscenegraph.org> för Robert Osfield <robert.osfield at gmail.com>
Skickat: den 4 juni 2016 19:42:10
Till: OpenSceneGraph Users
Ämne: Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hi François,

I have removed the register keyword usage from
Matrix_implementation.cpp and added the "" to the CMakeLists.txt.
These changes are now checked into git mater.

Robert.

On 4 June 2016 at 16:23, François Bérard <francois.berard at imag.fr> wrote:
> Hi Robert,
>
> On 3/6/16 18:46, Robert Osfield wrote:
>>
>> Rather than add this to the root CMakeLists.txt file I have added a
>> Clang specific section to the src/osgPlugins/cfg/CMakeLists.txt thus:
>>
>> # lex/yacc generated files use register that causes warnings with
>> CLang under OSX so disable this warnings.
>> IF(${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang")
>>     SET(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} -Wno-deprecated-register)
>> ENDIF()
>>
>> This is now checked into master.  Could remove you your own mds and test
>> this?
>
>
> there is a small pb which breaks the build:
>
> Scanning dependencies of target osgdb_cfg
> [ 79%] Building CXX object
> src/osgPlugins/cfg/CMakeFiles/osgdb_cfg.dir/CameraConfig.cpp.o
> clang: error: no input files
> /bin/sh: -Wno-deprecated-register: command not found
> make[2]: ***
> [src/osgPlugins/cfg/CMakeFiles/osgdb_cfg.dir/CameraConfig.cpp.o] Error 127
> make[1]: *** [src/osgPlugins/cfg/CMakeFiles/osgdb_cfg.dir/all] Error 2
> make: *** [all] Error 2
>
>
> adding double quotes fixes it:
>
>      SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-deprecated-register")
>
> Also, the warning appears in osg/Matrix_implementation.cpp (see attached
> log), you may want to add the definition to the CMakelist of libosg. I tried
> by adding the IF block juste before the SETUP_LIBRARY, it worked. But
> removing the two register keywords in the matrix code may be the best
> approach: they are most probably always ignored by the compilers.
>
> _______________________________________________
> osg-users mailing list
> osg-users at lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
_______________________________________________
osg-users mailing list
osg-users at lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: CMakeLists.txt
URL: <http://lists.openscenegraph.org/pipermail/osg-users-openscenegraph.org/attachments/20160605/d1982b5b/attachment-0003.txt>