[osg-users] Preparing to make 3.5.3 dev release, please test

[Robert Osfield]

Hi François,


On 3 June 2016 at 17:13, François Bérard <francois.berard at imag.fr> wrote:
>> I can seen anywhere where the OSG Cmake build system is adding
>> -Wdeprecated-register.  Are you adding this manually?
>
>
> nope. unzip, cmake, make. This must be a new default on my Clang (Apple LLVM
> version 7.3.0 (clang-703.0.29))
>
> I silenced the warnings by adding:
>
>         add_compile_options(-Wno-deprecated-register)

Rather than add this to the root CMakeLists.txt file I have added a
Clang specific section to the src/osgPlugins/cfg/CMakeLists.txt thus:

# lex/yacc generated files use register that causes warnings with
CLang under OSX so disable this warnings.
IF(${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang")
   SET(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} -Wno-deprecated-register)
ENDIF()

This is now checked into master.  Could remove you your own mds and test this?

> Doing so, the only warnings that remain are calls to deprecated OSX
> functions on 2 modules:
>

I will have to defer to yourself and other members of the OSG/OSX
community to suggest ways to resolve this warnings.

The two routes would seem to be to update the API usage so it's not
deprecated, this would the cleanest but could break backwards
compatibility if the new API's only exist in modern versions of the
OSX - we would need to check how far new API usage goes and decide as
a community whether this is far enough back.  The other approach is to
see if we can disable these warnings, this is a bit hacky though...

For the OSG-3.5.3 dev release I'm happy to leave these deprecated
warnings in place and let the OSG/OSX community tackle the deprecated
warnings.  The OSG/OSX isn't a large contingent so those who do use
the platform will be engage to make sure we don't end up breaking
things on certain OSX/iOS combinations.

Cheers,
Robert.