[osg-users] GL Error vulnerability in OSG 3.4.0 (invalid enum)

[Rick Irons]

Hi Robert,

Sorry for the delay in responding.  Thanks for the info below.

I will investigate if the GL_MAX_3D_TEXTURE_SIZE and GL_MAX_ARRAY_TEXTURE_LAYERS_EXT enumerations have GLES counterparts that need to be considered.

In regards to the fallback, wouldn’t the existing initialization of the two values to zero be sufficient?

We encountered this issue of unexpected GL errors in some tests that exercise Microsoft’s OpenGL 1.1 software implementation.  We use this version of OpenGL as a fallback when issues with hardware graphics OpenGL are encountered.

Thanks,
Rick

From: osg-users [mailto:osg-users-bounces at lists.openscenegraph.org] On Behalf Of Robert Osfield
Sent: Thursday, June 30, 2016 11:39 AM
To: OpenSceneGraph Users <osg-users at lists.openscenegraph.org>
Subject: Re: [osg-users] GL Error vulnerability in OSG 3.4.0 (invalid enum)

Hi Rick,
If we need to protect the testing of certain features for certain drivers then glVersion number probably isn't sufficient as we have GL and GLES versions to consider.
Another thing we'd need to do is provide a fallback in case we don't set the associated values.
BTW, what platform and GL versions are you seeing issus with?

Robert.

On 30 June 2016 at 16:34, Rick Irons <Rick.Irons at mathworks.com<mailto:Rick.Irons at mathworks.com>> wrote:
Hi,

openscenegraph/src/osg/GLExtensions.cpp should probably be checking the OpenGL version prior to using the GL_MAX_3D_TEXTURE_SIZE and GL_MAX_ARRAY_TEXTURE_LAYERS_EXT enums (see change below).  Otherwise, such calls will generate GL errors when using older versions of OpenGL.  Any concerns with such a change?

Thanks,
Rick
[cid:image001.png at 01D1E1B0.3CFA8600]

_______________________________________________
osg-users mailing list
osg-users at lists.openscenegraph.org<mailto:osg-users at lists.openscenegraph.org>
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openscenegraph.org/pipermail/osg-users-openscenegraph.org/attachments/20160719/0aaba0bc/attachment-0002.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 74127 bytes
Desc: image001.png
URL: <http://lists.openscenegraph.org/pipermail/osg-users-openscenegraph.org/attachments/20160719/0aaba0bc/attachment-0002.png>