[osg-users] osgShadow::MinimalShadowMap::ViewData::computeScenePolytopeBounds ... causes crash on Mac, fix proposed

[Trajce Nikolov NICK]

Hi Robert,

tested on OS X and works fine. Thanks !

Nick

On Tue, Apr 28, 2015 at 6:01 PM, Robert Osfield <robert.osfield at gmail.com>
wrote:

> Hi Nick,
>
> The code looks pretty dodgy so I'm not surprised it crashes, just that
> surprised we hadn't spotted it sooner.  A better solution is to have
> two methods, one that takes a matrix and one takes no parameters.  I
> have implemented this and checked it into svn/trunk.
>
> Could you test it out under OSX for me?
>
> Cheers,
> Robert
>
> On 28 April 2015 at 16:25, Trajce Nikolov NICK
> <trajce.nikolov.nick at gmail.com> wrote:
> > Hi Robert,
> >
> > as is defined like:
> >
> > osg::BoundingBox computeScenePolytopeBounds( const osg::Matrix & m =
> > *(osg::Matrix*)(NULL));
> >
> > when using it without passing a matrix it causes crash with g++ on OS X
> > (Windows and Linux are fine).
> >
> > Here is the proposed fix
> >
> > osg::BoundingBox computeScenePolytopeBounds( const osg::Matrix & m =
> > osg::Matrix::identity() );
> >
> > In the implementation it wont matter since when the matrix reference "is
> not
> > NULL reference" is multiplying vertices with it
> >
> > What do you think?
> >
> > Nick
> >
> > --
> > trajce nikolov nick
> >
> > _______________________________________________
> > osg-users mailing list
> > osg-users at lists.openscenegraph.org
> >
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
> >
> _______________________________________________
> osg-users mailing list
> osg-users at lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>



-- 
trajce nikolov nick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openscenegraph.org/pipermail/osg-users-openscenegraph.org/attachments/20150429/45aa5812/attachment-0002.htm>